Skip to content

fix: fix checking presence of type mapping to interface object#1201

Merged
devsergiy merged 1 commit intomasterfrom
sergiy/eng-7402-fix-problem-with-unwrapping-interface-object-selections
Jul 2, 2025
Merged

fix: fix checking presence of type mapping to interface object#1201
devsergiy merged 1 commit intomasterfrom
sergiy/eng-7402-fix-problem-with-unwrapping-interface-object-selections

Conversation

@devsergiy
Copy link
Copy Markdown
Member

@devsergiy devsergiy commented Jul 2, 2025 •
edited by coderabbitai Bot
Loading

Summary by CodeRabbit

  • Bug Fixes

    • Improved handling of interface objects with concrete type fragments to ensure correct query processing in certain federation scenarios.

  • Tests

    • Added a new test case to verify that queries involving interface objects and concrete type fragments are handled without unnecessary rewriting.

Checklist

  • I have discussed my proposed changes in an issue and have received approval to proceed.
  • I have followed the coding standards of the project.
  • Tests or benchmarks have been added or updated.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Jul 2, 2025 •
edited
Loading

Walkthrough

The function responsible for retrieving field type names from the upstream schema was updated to include an additional lookup step for interface objects when the enclosing type is not found. A new test case was introduced to verify the selection rewriter's behavior with interface objects and concrete type fragments, ensuring correct handling without rewriting.

Changes

File(s) Change Summary
v2/pkg/engine/plan/abstract_selection_rewriter_helpers.go Enhanced the logic in fieldTypeNameFromUpstreamSchema to handle interface objects when enclosing type is missing.
v2/pkg/engine/plan/abstract_selection_rewriter_test.go Added a test case for interface objects with concrete type fragments to the selection rewriter tests.
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e075100 and 6046a0f.

📒 Files selected for processing (2)
  • v2/pkg/engine/plan/abstract_selection_rewriter_helpers.go (1 hunks)
  • v2/pkg/engine/plan/abstract_selection_rewriter_test.go (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • v2/pkg/engine/plan/abstract_selection_rewriter_helpers.go
  • v2/pkg/engine/plan/abstract_selection_rewriter_test.go
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build and test (go 1.23 / windows-latest)
  • GitHub Check: Build and test (go 1.23 / windows-latest)
✨ Finishing Touches
  • 📝 Generate Docstrings
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@devsergiy devsergiy force-pushed the sergiy/eng-7402-fix-problem-with-unwrapping-interface-object-selections branch from e075100 to 6046a0f Compare July 2, 2025 02:03
@devsergiy devsergiy merged commit 0a849ee into master Jul 2, 2025
10 checks passed
@devsergiy devsergiy deleted the sergiy/eng-7402-fix-problem-with-unwrapping-interface-object-selections branch July 2, 2025 02:11
@StarpTech StarpTech mentioned this pull request Jul 2, 2025
Merged
devsergiy pushed a commit that referenced this pull request Jul 2, 2025
@StarpTech
chore(master): release 2.0.0-rc.195 (#1202)
0a37383 
🤖 I have created a release *beep* *boop*
---


##
[2.0.0-rc.195](v2.0.0-rc.194...v2.0.0-rc.195)
(2025-07-02)


### Bug Fixes

* fix checking presence of type mapping to interface object
([#1201](#1201))
([0a849ee](0a849ee))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

* **Bug Fixes**
* Resolved an issue with checking the presence of type mapping to
interface objects.

* **Documentation**
* Added a changelog entry for version 2.0.0-rc.195, detailing the latest
bug fix.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
devsergiy added a commit to wundergraph/cosmo that referenced this pull request Jul 2, 2025
@devsergiy
bump-engine: ## [2.0.0-rc.195](wundergraph/graphql-go-tools@v2.0.0-rc…
63b6abd 
….194...v2.0.0-rc.195) (2025-07-02)

### Bug Fixes
* fix checking presence of type mapping to interface object ([#1201](wundergraph/graphql-go-tools#1201)) ([0a849ee](wundergraph/graphql-go-tools@0a849ee))
@devsergiy devsergiy mentioned this pull request Jul 2, 2025
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Noroth Noroth Awaiting requested review from Noroth Noroth is a code owner

@StarpTech StarpTech Awaiting requested review from StarpTech StarpTech is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@devsergiy